Simplify bytecode instrumentation implementation#2094
Closed
fractalwrench wants to merge 1 commit intomainfrom
Closed
Simplify bytecode instrumentation implementation#2094fractalwrench wants to merge 1 commit intomainfrom
fractalwrench wants to merge 1 commit intomainfrom
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
fractalwrench
force-pushed
the
refactor-bytecode-instrumentation
branch
3 times, most recently
from
8a59a4e to
09417d7
Compare
There was a problem hiding this comment.
Copilot reviewed 28 out of 28 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
embrace-gradle-plugin/src/main/java/io/embrace/android/gradle/plugin/instrumentation/visitor/WebViewClientOverrideMethodAdapter.kt:30
- Calling visitInsn(Opcodes.RETURN) after super.visitEnd() may be redundant or lead to unreachable code; please verify if this extra RETURN instruction is necessary.
visitInsn(Opcodes.RETURN)
09417d7 to
5b36b41
Compare
fractalwrench
force-pushed
the
refactor-bytecode-instrumentation
branch
from
5b36b41 to
3606d52
Compare
priettt
approved these changes
Apr 15, 2025
Contributor
priettt
left a comment
priettt
left a comment
There was a problem hiding this comment.
Looks good! Why did we need a WebViewClientOverride?
fractalwrench
force-pushed
the
refactor-bytecode-instrumentation
branch
from
3606d52 to
ae17a86
Compare
Member
Author
|
The bytecode instrumentation is different depending on whether the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Begins refactoring bytecode instrumentation by creating a single
MethodVisitorthat can be configured via its parameters to instrument a specific function in a given class.Testing
Relied on existing test coverage.